Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove basic-auth useless annotation #1779

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Feb 19, 2025

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

fixes #1741

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni johnlanni merged commit 7f23980 into alibaba:main Feb 19, 2025
4 checks passed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.35%. Comparing base (ef31e09) to head (3800672).
Report is 299 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/kube/annotations/auth.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1779      +/-   ##
==========================================
+ Coverage   35.91%   43.35%   +7.44%     
==========================================
  Files          69       76       +7     
  Lines       11576    12278     +702     
==========================================
+ Hits         4157     5323    +1166     
+ Misses       7104     6625     -479     
- Partials      315      330      +15     
Files with missing lines Coverage Δ
pkg/ingress/kube/annotations/auth.go 0.00% <0.00%> (-66.30%) ⬇️

... and 70 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants